Omitting /tmp directory from download archive contents

Have a good idea ? Want to suggest something ? Have a couple of lines of code to back it up ?
Post it here !

Omitting /tmp directory from download archive contents

Postby wolf on 05-09-2007 07:58

This suggestion is related this bug, as the suggestion can easily be incorporated as part of the bug fix.

When I download an album, the .tar file includes the /tmp directory, which isn't really desired. It is also quite unnecessary, because in the download.php file you can just change directory to the /tmp directory by prepending a "cd tmp;" in the exec call to the tar command.

Of course, the files that are to be combined must have /tmp stripped from their names, but I seem to recall you're actually adding "/tmp" to your filenames somewhere in the download.php script, so this is probably dead easy.
wolf
AmpJuke user
AmpJuke user
 
Posts: 35
Joined: 14-08-2007 22:06
Location: Aalborg, Denmark

Postby Michael on 23-09-2007 19:30

Done :)
No more 'tmp' in the .tar-files, starting from release 0.6.4, which I expect to release soon.

However, I must also complete a nice new ajax-enabled feature for the 0.6.4 release, - I'm almost there.

Anyway, your nice suggestion - "cd tmp; " - worked (with a couple of 'tweaks').
Thanks.

//Michael.
User avatar
Michael
Site Admin
Site Admin
 
Posts: 449
Joined: 03-07-2007 13:46
Location: Denmark

Postby wolf on 27-09-2007 08:07

Michael wrote:Anyway, your nice suggestion - "cd tmp; " - worked (with a couple of 'tweaks').

Impressive--that may be the most diplomatic way to phrase "your suggestion didn't work" I've ever heard. :)
wolf
AmpJuke user
AmpJuke user
 
Posts: 35
Joined: 14-08-2007 22:06
Location: Aalborg, Denmark

Postby Michael on 27-09-2007 10:57

Thanks :)

Just to get this straight: Your suggestion did work, actually.

//Michael.
User avatar
Michael
Site Admin
Site Admin
 
Posts: 449
Joined: 03-07-2007 13:46
Location: Denmark


Return to Requests / suggestions

Who is online

Users browsing this forum: No registered users and 1 guest

cron